Network SDK with API version 2018-05-01#4333
Merged
dsgouda merged 2 commits intoAzure:psSdkJson6from May 17, 2018
Merged
Conversation
Contributor
|
hi @dsgouda please review new major SDK version. Address all the comments for me so I can help with the fixes |
dsgouda
suggested changes
May 17, 2018
Contributor
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
Looks great apart from the minor comment.
| @@ -1,11 +1,11 @@ | |||
| 2018-04-26 20:59:33 UTC | |||
| 2018-05-17 13:34:00 UTC | |||
Contributor
There was a problem hiding this comment.
@MikhailTryakhov please generate the sdk using this script instead
dsgouda
approved these changes
May 17, 2018
Contributor
dsgouda
left a comment
dsgouda
left a comment
There was a problem hiding this comment.
Approving this for now since some teams need the nuget package soon
This was referenced Jun 15, 2023
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on: Azure/azure-rest-api-specs#3089
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.